summaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/core/mad.c
diff options
context:
space:
mode:
authorLeon Romanovsky <leonro@mellanox.com>2018-05-29 14:56:19 +0300
committerDoug Ledford <dledford@redhat.com>2018-06-01 11:16:24 -0400
commit2468b82d69e3a53d024f28d79ba0fdb8bf43dfbf (patch)
tree1c76bffaf8250a032f2257b9cc0bf810fd782427 /drivers/infiniband/core/mad.c
parentdee92c4bf53b2701d382ce9e32c57d194a393bfe (diff)
downloadlinux-2468b82d69e3a53d024f28d79ba0fdb8bf43dfbf.tar.gz
linux-2468b82d69e3a53d024f28d79ba0fdb8bf43dfbf.tar.bz2
linux-2468b82d69e3a53d024f28d79ba0fdb8bf43dfbf.zip
RDMA/mad: Convert BUG_ONs to error flows
Let's perform checks in-place instead of BUG_ONs. Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/core/mad.c')
-rw-r--r--drivers/infiniband/core/mad.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 35295e74de04..f742ae7a768b 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -1556,7 +1556,8 @@ static int add_oui_reg_req(struct ib_mad_reg_req *mad_reg_req,
mad_reg_req->oui, 3)) {
method = &(*vendor_table)->vendor_class[
vclass]->method_table[i];
- BUG_ON(!*method);
+ if (!*method)
+ goto error3;
goto check_in_use;
}
}
@@ -1566,10 +1567,12 @@ static int add_oui_reg_req(struct ib_mad_reg_req *mad_reg_req,
vclass]->oui[i])) {
method = &(*vendor_table)->vendor_class[
vclass]->method_table[i];
- BUG_ON(*method);
/* Allocate method table for this OUI */
- if ((ret = allocate_method_table(method)))
- goto error3;
+ if (!*method) {
+ ret = allocate_method_table(method);
+ if (ret)
+ goto error3;
+ }
memcpy((*vendor_table)->vendor_class[vclass]->oui[i],
mad_reg_req->oui, 3);
goto check_in_use;