diff options
| author | Chengchang Tang <tangchengchang@huawei.com> | 2023-10-17 20:52:34 +0800 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2023-10-19 09:49:40 +0300 |
| commit | c64e9710f9241e38a1c761ed1c1a30854784da66 (patch) | |
| tree | 81d0cc859458e0cadeba9b3885d135bd4e612ff7 /drivers/infiniband/hw/hns | |
| parent | 9faef73ef4f6666b97e04d99734ac09251098185 (diff) | |
| download | linux-c64e9710f9241e38a1c761ed1c1a30854784da66.tar.gz linux-c64e9710f9241e38a1c761ed1c1a30854784da66.tar.bz2 linux-c64e9710f9241e38a1c761ed1c1a30854784da66.zip | |
RDMA/hns: Fix uninitialized ucmd in hns_roce_create_qp_common()
ucmd in hns_roce_create_qp_common() are not initialized. But it works fine
until new member sdb_addr is added to struct hns_roce_ib_create_qp.
If the user-mode driver uses an old version ABI, then the value of the new
member will be undefined after ib_copy_from_udata().
This patch fixes it by initialize this variable to 0. And the default value
of the new member sdb_addr will be 0 which is invalid.
Fixes: 0425e3e6e0c7 ("RDMA/hns: Support flush cqe for hip08 in kernel space")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20231017125239.164455-3-huangjunxian6@hisilicon.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/hw/hns')
| -rw-r--r-- | drivers/infiniband/hw/hns/hns_roce_qp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c index cdc1c6de43a1..828b58534aa9 100644 --- a/drivers/infiniband/hw/hns/hns_roce_qp.c +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c @@ -1064,7 +1064,7 @@ static int hns_roce_create_qp_common(struct hns_roce_dev *hr_dev, { struct hns_roce_ib_create_qp_resp resp = {}; struct ib_device *ibdev = &hr_dev->ib_dev; - struct hns_roce_ib_create_qp ucmd; + struct hns_roce_ib_create_qp ucmd = {}; int ret; mutex_init(&hr_qp->mutex); |