diff options
| author | Devesh Sharma <devesh.sharma@broadcom.com> | 2018-02-15 21:20:10 -0800 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2018-02-20 11:57:21 -0500 |
| commit | 6b4521f5174c26020ae0deb3ef7f2c28557cf445 (patch) | |
| tree | bf521bc40449f94ed64c1e164c503e4787f19016 /drivers/infiniband/hw | |
| parent | 7ff662b76167fd9a68254352287c5de0dc698942 (diff) | |
| download | linux-6b4521f5174c26020ae0deb3ef7f2c28557cf445.tar.gz linux-6b4521f5174c26020ae0deb3ef7f2c28557cf445.tar.bz2 linux-6b4521f5174c26020ae0deb3ef7f2c28557cf445.zip | |
RDMA/bnxt_re: Unpin SQ and RQ memory if QP create fails
Driver leaves the QP memory pinned if QP create command
fails from the FW. Avoids this scenario by adding a proper
exit path if the FW command fails.
Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw')
| -rw-r--r-- | drivers/infiniband/hw/bnxt_re/ib_verbs.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index 280354ffa642..29e6b1736504 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1183,7 +1183,7 @@ struct ib_qp *bnxt_re_create_qp(struct ib_pd *ib_pd, rc = bnxt_qplib_create_qp(&rdev->qplib_res, &qp->qplib_qp); if (rc) { dev_err(rdev_to_dev(rdev), "Failed to create HW QP"); - goto fail; + goto free_umem; } } @@ -1211,6 +1211,13 @@ struct ib_qp *bnxt_re_create_qp(struct ib_pd *ib_pd, return &qp->ib_qp; qp_destroy: bnxt_qplib_destroy_qp(&rdev->qplib_res, &qp->qplib_qp); +free_umem: + if (udata) { + if (qp->rumem) + ib_umem_release(qp->rumem); + if (qp->sumem) + ib_umem_release(qp->sumem); + } fail: kfree(qp); return ERR_PTR(rc); |