summaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/ulp/iser/iscsi_iser.c
diff options
context:
space:
mode:
authorMax Gurtovoy <maxg@mellanox.com>2017-01-18 00:40:39 +0200
committerDoug Ledford <dledford@redhat.com>2017-01-24 11:37:45 -0500
commit1e5db6c31ade4150c2e2b1a21e39f776c38fea39 (patch)
treebadaf77660460ad816aec11c42dc6e96299819d2 /drivers/infiniband/ulp/iser/iscsi_iser.c
parent0a475ef4226e305bdcffe12b401ca1eab06c4913 (diff)
downloadlinux-1e5db6c31ade4150c2e2b1a21e39f776c38fea39.tar.gz
linux-1e5db6c31ade4150c2e2b1a21e39f776c38fea39.tar.bz2
linux-1e5db6c31ade4150c2e2b1a21e39f776c38fea39.zip
IB/iser: Fix sg_tablesize calculation
For devices that can register page list that is bigger than USHRT_MAX, we actually take the wrong value for sg_tablesize. E.g: for CX4 max_fast_reg_page_list_len is 65536 (bigger than USHRT_MAX) so we set sg_tablesize to 0 by mistake. Therefore, each IO that is bigger than 4k splitted to "< 4k" chunks that cause performance degredation. Remove wrong sg_tablesize assignment, and use the value that was set during address resolution handler with the needed casting. Cc: <stable@vger.kernel.org> # v4.5+ Signed-off-by: Max Gurtovoy <maxg@mellanox.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/ulp/iser/iscsi_iser.c')
-rw-r--r--drivers/infiniband/ulp/iser/iscsi_iser.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 9104e6b8cac9..1c911876556e 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -651,13 +651,6 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep,
SHOST_DIX_GUARD_CRC);
}
- /*
- * Limit the sg_tablesize and max_sectors based on the device
- * max fastreg page list length.
- */
- shost->sg_tablesize = min_t(unsigned short, shost->sg_tablesize,
- ib_conn->device->ib_device->attrs.max_fast_reg_page_list_len);
-
if (iscsi_host_add(shost,
ib_conn->device->ib_device->dma_device)) {
mutex_unlock(&iser_conn->state_mutex);