summaryrefslogtreecommitdiffstats
path: root/drivers/isdn
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2018-07-27 10:45:30 +0800
committerDavid S. Miller <davem@davemloft.net>2018-07-26 21:23:16 -0700
commit87935aa776caae9c8346797271d19fa710b65a6a (patch)
treed91de649eadf3ee83df5ded3c9206b273caac4f3 /drivers/isdn
parent9d8009dee92cc97f866403da1b306e6e29fc12cc (diff)
downloadlinux-87935aa776caae9c8346797271d19fa710b65a6a.tar.gz
linux-87935aa776caae9c8346797271d19fa710b65a6a.tar.bz2
linux-87935aa776caae9c8346797271d19fa710b65a6a.zip
isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack()
init_PStack() is never called in atomic context. It calls kmalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
-rw-r--r--drivers/isdn/hisax/callc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c
index 5f43783039d4..9ee06328784c 100644
--- a/drivers/isdn/hisax/callc.c
+++ b/drivers/isdn/hisax/callc.c
@@ -1012,7 +1012,7 @@ dummy_pstack(struct PStack *st, int pr, void *arg) {
static int
init_PStack(struct PStack **stp) {
- *stp = kmalloc(sizeof(struct PStack), GFP_ATOMIC);
+ *stp = kmalloc(sizeof(struct PStack), GFP_KERNEL);
if (!*stp)
return -ENOMEM;
(*stp)->next = NULL;