diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2023-04-19 23:07:39 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-05-25 12:07:34 +0100 |
| commit | cee4bd16c3195a701be683f7da9e88c6e11acb73 (patch) | |
| tree | 4a366d139bf96c1e6d77d3a91b994112157f499d /drivers/leds/trigger | |
| parent | ac9a78681b921877518763ba0e89202254349d1b (diff) | |
| download | linux-cee4bd16c3195a701be683f7da9e88c6e11acb73.tar.gz linux-cee4bd16c3195a701be683f7da9e88c6e11acb73.tar.bz2 linux-cee4bd16c3195a701be683f7da9e88c6e11acb73.zip | |
leds: trigger: netdev: Recheck NETDEV_LED_MODE_LINKUP on dev rename
Dev can be renamed also while up for supported device. We currently
wrongly clear the NETDEV_LED_MODE_LINKUP flag on NETDEV_CHANGENAME
event.
Fix this by rechecking if the carrier is ok on NETDEV_CHANGENAME and
correctly set the NETDEV_LED_MODE_LINKUP bit.
Fixes: 5f820ed52371 ("leds: trigger: netdev: fix handling on interface rename")
Cc: stable@vger.kernel.org # v5.5+
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230419210743.3594-2-ansuelsmth@gmail.com
Diffstat (limited to 'drivers/leds/trigger')
| -rw-r--r-- | drivers/leds/trigger/ledtrig-netdev.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index d5e774d83021..f4d670ec30bc 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -318,6 +318,9 @@ static int netdev_trig_notify(struct notifier_block *nb, clear_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode); switch (evt) { case NETDEV_CHANGENAME: + if (netif_carrier_ok(dev)) + set_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode); + fallthrough; case NETDEV_REGISTER: if (trigger_data->net_dev) dev_put(trigger_data->net_dev); |