diff options
| author | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2024-02-23 12:25:55 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2024-05-02 18:59:09 +0100 |
| commit | 42bcaacae924bf18ae387c3f78c202df0b739292 (patch) | |
| tree | 545bc5bfe22697778178f6798d7919ef2128871c /drivers/media/cec/core | |
| parent | 9fe2816816a3c765dff3b88af5b5c3d9bbb911ce (diff) | |
| download | linux-42bcaacae924bf18ae387c3f78c202df0b739292.tar.gz linux-42bcaacae924bf18ae387c3f78c202df0b739292.tar.bz2 linux-42bcaacae924bf18ae387c3f78c202df0b739292.zip | |
media: cec: cec-api: add locking in cec_release()
When cec_release() uses fh->msgs it has to take fh->lock,
otherwise the list can get corrupted.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Yang, Chenyuan <cy54@illinois.edu>
Closes: https://lore.kernel.org/linux-media/PH7PR11MB57688E64ADE4FE82E658D86DA09EA@PH7PR11MB5768.namprd11.prod.outlook.com/
Fixes: ca684386e6e2 ("[media] cec: add HDMI CEC framework (api)")
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/cec/core')
| -rw-r--r-- | drivers/media/cec/core/cec-api.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/media/cec/core/cec-api.c b/drivers/media/cec/core/cec-api.c index 67dc79ef1705..d64bb716f9c6 100644 --- a/drivers/media/cec/core/cec-api.c +++ b/drivers/media/cec/core/cec-api.c @@ -664,6 +664,8 @@ static int cec_release(struct inode *inode, struct file *filp) list_del_init(&data->xfer_list); } mutex_unlock(&adap->lock); + + mutex_lock(&fh->lock); while (!list_empty(&fh->msgs)) { struct cec_msg_entry *entry = list_first_entry(&fh->msgs, struct cec_msg_entry, list); @@ -681,6 +683,7 @@ static int cec_release(struct inode *inode, struct file *filp) kfree(entry); } } + mutex_unlock(&fh->lock); kfree(fh); cec_put_device(devnode); |