summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/rcar_fdp1.c
diff options
context:
space:
mode:
authorGustavo A. R. Silva <garsilva@embeddedor.com>2017-07-06 16:25:32 -0400
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-07-19 15:03:55 -0400
commit0169daec966598859fb5cd76f11a7a720e721f89 (patch)
tree9f66e671f649dac4a90eebcbf0da873859a3e2f5 /drivers/media/platform/rcar_fdp1.c
parent7e645125a88b4fd5611fc09a2800e71b34963580 (diff)
downloadlinux-0169daec966598859fb5cd76f11a7a720e721f89.tar.gz
linux-0169daec966598859fb5cd76f11a7a720e721f89.tar.bz2
linux-0169daec966598859fb5cd76f11a7a720e721f89.zip
media: rcar_fdp1: constify vb2_ops structure
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p = { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/platform/rcar_fdp1.c')
-rw-r--r--drivers/media/platform/rcar_fdp1.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
index 3ee51fc3bb50..3245bc45f4a0 100644
--- a/drivers/media/platform/rcar_fdp1.c
+++ b/drivers/media/platform/rcar_fdp1.c
@@ -2032,7 +2032,7 @@ static void fdp1_stop_streaming(struct vb2_queue *q)
}
}
-static struct vb2_ops fdp1_qops = {
+static const struct vb2_ops fdp1_qops = {
.queue_setup = fdp1_queue_setup,
.buf_prepare = fdp1_buf_prepare,
.buf_queue = fdp1_buf_queue,