summaryrefslogtreecommitdiffstats
path: root/drivers/misc/ad525x_dpot.h
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-11-21 23:43:39 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-23 19:49:22 +0100
commit27158c72678b39ee01cc01de1aba6b51c71abe2f (patch)
treedcc108eacd18df31020b0ff40974e41aef5e6863 /drivers/misc/ad525x_dpot.h
parenta4cb1004aeed2ab893a058fad00a5b41a12c4691 (diff)
downloadlinux-27158c72678b39ee01cc01de1aba6b51c71abe2f.tar.gz
linux-27158c72678b39ee01cc01de1aba6b51c71abe2f.tar.bz2
linux-27158c72678b39ee01cc01de1aba6b51c71abe2f.zip
ocxl: fix pci device refcount leak when calling get_function_0()
get_function_0() calls pci_get_domain_bus_and_slot(), as comment says, it returns a pci device with refcount increment, so after using it, pci_dev_put() needs be called. Get the device reference when get_function_0() is not called, so pci_dev_put() can be called in the error path and callers unconditionally. And add comment above get_dvsec_vendor0() to tell callers to call pci_dev_put(). Fixes: 87db7579ebd5 ("ocxl: control via sysfs whether the FPGA is reloaded on a link reset") Suggested-by: Andrew Donnellan <ajd@linux.ibm.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Andrew Donnellan <ajd@linux.ibm.com> Link: https://lore.kernel.org/r/20221121154339.4088935-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/ad525x_dpot.h')
0 files changed, 0 insertions, 0 deletions