diff options
| author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2012-10-23 14:08:52 +0200 |
|---|---|---|
| committer | Chris Ball <cjb@laptop.org> | 2012-11-07 15:02:02 -0500 |
| commit | a0d28ba01ebd048b4ba418142b37f5cf80e6d156 (patch) | |
| tree | c37eb5131c5ac5569221f4f61eb7c54c839183fe /drivers/mmc | |
| parent | 90b3e6c53b006d55952183d8ada2ce3ebc0dce06 (diff) | |
| download | linux-a0d28ba01ebd048b4ba418142b37f5cf80e6d156.tar.gz linux-a0d28ba01ebd048b4ba418142b37f5cf80e6d156.tar.bz2 linux-a0d28ba01ebd048b4ba418142b37f5cf80e6d156.zip | |
mmc: sh_mmcif: fix use after free
A recent commit "mmc: sh_mmcif: fix clock management" has introduced a
use after free bug in sh_mmcif.c: in sh_mmcif_remove() the call to
mmc_free_host() frees private driver data, therefore using it afterwards
is a bug. Revert that hunk.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: stable@vger.kernel.org [3.6]
Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc')
| -rw-r--r-- | drivers/mmc/host/sh_mmcif.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 11d2bc3b51d5..d25bc97dc5c6 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1466,9 +1466,9 @@ static int __devexit sh_mmcif_remove(struct platform_device *pdev) platform_set_drvdata(pdev, NULL); + clk_disable(host->hclk); mmc_free_host(host->mmc); pm_runtime_put_sync(&pdev->dev); - clk_disable(host->hclk); pm_runtime_disable(&pdev->dev); return 0; |