diff options
| author | Fengguang Wu <fengguang.wu@intel.com> | 2018-03-06 23:54:07 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-07 13:33:23 -0500 |
| commit | b1312b85012245923b5cb59ac324a5649eefefcb (patch) | |
| tree | 42a3467f2da98e8c7d971ec310c3c09554f33017 /drivers/net/dsa/mv88e6xxx/serdes.c | |
| parent | 630b21a26ae02bd180aebbccad248c64daf1da4b (diff) | |
| download | linux-b1312b85012245923b5cb59ac324a5649eefefcb.tar.gz linux-b1312b85012245923b5cb59ac324a5649eefefcb.tar.bz2 linux-b1312b85012245923b5cb59ac324a5649eefefcb.zip | |
net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
CC: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/mv88e6xxx/serdes.c')
| -rw-r--r-- | drivers/net/dsa/mv88e6xxx/serdes.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c index 4756969c1546..b6166424216a 100644 --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -63,15 +63,15 @@ static bool mv88e6352_port_has_serdes(struct mv88e6xxx_chip *chip, int port) err = mv88e6xxx_port_get_cmode(chip, port, &cmode); if (err) { dev_err(chip->dev, "failed to read cmode\n"); - return 0; + return false; } if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) || (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) || (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII)) - return 1; + return true; - return 0; + return false; } int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on) |