summaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa
diff options
context:
space:
mode:
authorGuobin Huang <huangguobin4@huawei.com>2021-03-29 09:54:05 +0800
committerDavid S. Miller <davem@davemloft.net>2021-03-29 13:16:44 -0700
commita180be79db4a7eeab575b76b0838087932953caf (patch)
tree6d9416a5436edf2d3f253b72ead9a8e222dd0eba /drivers/net/dsa
parent3d0dbd546345689aba8c4a00b486abc51622e920 (diff)
downloadlinux-a180be79db4a7eeab575b76b0838087932953caf.tar.gz
linux-a180be79db4a7eeab575b76b0838087932953caf.tar.bz2
linux-a180be79db4a7eeab575b76b0838087932953caf.zip
net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Guobin Huang <huangguobin4@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
-rw-r--r--drivers/net/dsa/ocelot/felix_vsc9959.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 5ff623ee76a6..789fe08cae50 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1057,10 +1057,8 @@ static int vsc9959_mdio_bus_alloc(struct ocelot *ocelot)
res.end += felix->imdio_base;
imdio_regs = devm_ioremap_resource(dev, &res);
- if (IS_ERR(imdio_regs)) {
- dev_err(dev, "failed to map internal MDIO registers\n");
+ if (IS_ERR(imdio_regs))
return PTR_ERR(imdio_regs);
- }
hw = enetc_hw_alloc(dev, imdio_regs);
if (IS_ERR(hw)) {