diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-18 13:12:21 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-08-20 10:58:28 +0100 |
| commit | 32bbe64a1386065ab2aef8ce8cae7c689d0add6e (patch) | |
| tree | 8fb6b24826a8930c9bf36e06990917dd3800a172 /drivers/net/ethernet/broadcom/genet | |
| parent | 23a14488ea5882dea5851b65c9fce2127ee8fcad (diff) | |
| download | linux-32bbe64a1386065ab2aef8ce8cae7c689d0add6e.tar.gz linux-32bbe64a1386065ab2aef8ce8cae7c689d0add6e.tar.bz2 linux-32bbe64a1386065ab2aef8ce8cae7c689d0add6e.zip | |
net: bcmgenet: Fix return value check for fixed_phy_register()
The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.
Fixes: b0ba512e25d7 ("net: bcmgenet: enable driver to work without a device tree")
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 0092e46c46f8..cc3afb605b1e 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -617,7 +617,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) }; phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); - if (!phydev || IS_ERR(phydev)) { + if (IS_ERR(phydev)) { dev_err(kdev, "failed to register fixed PHY device\n"); return -ENODEV; } |