summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/ice/ice_main.c
diff options
context:
space:
mode:
authorVinicius Costa Gomes <vinicius.gomes@intel.com>2024-02-20 15:57:11 -0800
committerTony Nguyen <anthony.l.nguyen@intel.com>2024-03-06 09:20:23 -0800
commitee14cc9ea19ba9678177e2224a9c58cce5937c73 (patch)
tree9067bcb213aceca32816f8a8e3782338a0077f35 /drivers/net/ethernet/intel/ice/ice_main.c
parent244ae992e3e80e5c9c272c77324c831148457f95 (diff)
downloadlinux-ee14cc9ea19ba9678177e2224a9c58cce5937c73.tar.gz
linux-ee14cc9ea19ba9678177e2224a9c58cce5937c73.tar.bz2
linux-ee14cc9ea19ba9678177e2224a9c58cce5937c73.zip
igb: Fix missing time sync events
Fix "double" clearing of interrupts, which can cause external events or timestamps to be missed. The E1000_TSIRC Time Sync Interrupt Cause register can be cleared in two ways, by either reading it or by writing '1' into the specific cause bit. This is documented in section 8.16.1. The following flow was used: 1. read E1000_TSIRC into 'tsicr'; 2. handle the interrupts present into 'tsirc' and mark them in 'ack'; 3. write 'ack' into E1000_TSICR; As both (1) and (3) will clear the interrupt cause, if the same interrupt happens again between (1) and (3) it will be ignored, causing events to be missed. Remove the extra clear in (3). Fixes: 00c65578b47b ("igb: enable internal PPS for the i210") Acked-by: Richard Cochran <richardcochran@gmail.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_main.c')
0 files changed, 0 insertions, 0 deletions