diff options
| author | Subbaraya Sundeep <sbhatta@marvell.com> | 2020-07-25 10:13:54 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-28 17:14:48 -0700 |
| commit | ed543f5c6a988d8a863d2436794230cef2c82389 (patch) | |
| tree | 120b598b29da4609f533fedaba6d623a580dee66 /drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | |
| parent | c0376f473c5cc2ef94f8e1e055d173293cc3698c (diff) | |
| download | linux-ed543f5c6a988d8a863d2436794230cef2c82389.tar.gz linux-ed543f5c6a988d8a863d2436794230cef2c82389.tar.bz2 linux-ed543f5c6a988d8a863d2436794230cef2c82389.zip | |
octeontx2-pf: Unregister netdev at driver remove
Added unregister_netdev in the driver remove
function. Generally unregister_netdev is called
after disabling all the device interrupts but here
it is called before disabling device mailbox
interrupts. The reason behind this is VF needs
mailbox interrupt to communicate with its PF to
clean up its resources during otx2_stop.
otx2_stop disables packet I/O and queue interrupts
first and by using mailbox interrupt communicates
to PF to free VF resources. Hence this patch
calls unregister_device just before
disabling mailbox interrupts.
Fixes: 3184fb5ba96e ("octeontx2-vf: Virtual function driver support")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c')
| -rw-r--r-- | drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c index c1c263d1ac2e..92a3db69a6cd 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c @@ -618,6 +618,7 @@ static void otx2vf_remove(struct pci_dev *pdev) vf = netdev_priv(netdev); cancel_work_sync(&vf->reset_task); + unregister_netdev(netdev); otx2vf_disable_mbox_intr(vf); otx2_detach_resources(&vf->mbox); |