diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-03-14 23:00:09 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-03-16 12:56:45 -0700 |
| commit | 706217c1ceb516c96283a1557a31fe003d0c8052 (patch) | |
| tree | 765804a5cfb6868ff577cd56e44b1a6c823f3d72 /drivers/net/ethernet/netronome/nfp/nfp_port.c | |
| parent | 49e83bbe8cc32e197fccf4f617b3fa2fedc27a23 (diff) | |
| download | linux-706217c1ceb516c96283a1557a31fe003d0c8052.tar.gz linux-706217c1ceb516c96283a1557a31fe003d0c8052.tar.bz2 linux-706217c1ceb516c96283a1557a31fe003d0c8052.zip | |
devlink: pass devlink_port to port_split / port_unsplit callbacks
Now that devlink ports are protected by the instance lock
it seems natural to pass devlink_port as an argument to
the port_split / port_unsplit callbacks.
This should save the drivers from doing a lookup.
In theory drivers may have supported unsplitting ports
which were not registered prior to this change.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/netronome/nfp/nfp_port.c')
| -rw-r--r-- | drivers/net/ethernet/netronome/nfp/nfp_port.c | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_port.c b/drivers/net/ethernet/netronome/nfp/nfp_port.c index 236cd3c1201f..4f2308570dcf 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_port.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_port.c @@ -75,24 +75,6 @@ int nfp_port_set_features(struct net_device *netdev, netdev_features_t features) return 0; } -struct nfp_port * -nfp_port_from_id(struct nfp_pf *pf, enum nfp_port_type type, unsigned int id) -{ - struct devlink *devlink = priv_to_devlink(pf); - struct nfp_port *port; - - devl_assert_locked(devlink); - - if (type != NFP_PORT_PHYS_PORT) - return NULL; - - list_for_each_entry(port, &pf->ports, port_list) - if (port->eth_id == id) - return port; - - return NULL; -} - struct nfp_eth_table_port *__nfp_port_get_eth_port(struct nfp_port *port) { if (!port) |