diff options
| author | Sergey Shtylyov <s.shtylyov@omp.ru> | 2022-01-29 14:55:16 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-01-31 11:42:13 +0000 |
| commit | be94a51f3e5eee72ba4251c1b1c463872b03cf54 (patch) | |
| tree | 172969f94e488b57bae6916a95efa68bac74d9cf /drivers/net/ethernet/renesas | |
| parent | cc4598cf179ff636d7634008045905a88480bb88 (diff) | |
| download | linux-be94a51f3e5eee72ba4251c1b1c463872b03cf54.tar.gz linux-be94a51f3e5eee72ba4251c1b1c463872b03cf54.tar.bz2 linux-be94a51f3e5eee72ba4251c1b1c463872b03cf54.zip | |
ravb: ravb_close() always returns 0
ravb_close() always returns 0, hence the check in ravb_wol_restore() is
pointless (however, we cannot change the prototype of ravb_close() as it
implements the driver's ndo_stop() method).
Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/renesas')
| -rw-r--r-- | drivers/net/ethernet/renesas/ravb_main.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 80366661a361..24e2635c4c80 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -2848,7 +2848,6 @@ static int ravb_wol_restore(struct net_device *ndev) { struct ravb_private *priv = netdev_priv(ndev); const struct ravb_hw_info *info = priv->info; - int ret; if (info->nc_queues) napi_enable(&priv->napi[RAVB_NC]); @@ -2857,9 +2856,7 @@ static int ravb_wol_restore(struct net_device *ndev) /* Disable MagicPacket */ ravb_modify(ndev, ECMR, ECMR_MPDE, 0); - ret = ravb_close(ndev); - if (ret < 0) - return ret; + ravb_close(ndev); return disable_irq_wake(priv->emac_irq); } |