diff options
| author | Andy Chiu <andy.chiu@sifive.com> | 2024-07-26 15:06:50 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-07-29 11:35:37 +0100 |
| commit | 799a829507506924add8a7620493adc1c3cfda30 (patch) | |
| tree | ed38d7c826b8dc63bd997cc5da06293482d167cb /drivers/net/ethernet/xilinx | |
| parent | 05f76b2d634e65ab34472802d9b142ea9e03f74e (diff) | |
| download | linux-799a829507506924add8a7620493adc1c3cfda30.tar.gz linux-799a829507506924add8a7620493adc1c3cfda30.tar.bz2 linux-799a829507506924add8a7620493adc1c3cfda30.zip | |
net: axienet: start napi before enabling Rx/Tx
softirq may get lost if an Rx interrupt comes before we call
napi_enable. Move napi_enable in front of axienet_setoptions(), which
turns on the device, to address the issue.
Link: https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg06160.html
Fixes: cc37610caaf8 ("net: axienet: implement NAPI and GRO receive")
Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xilinx')
| -rw-r--r-- | drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index e342f387c3dd..02fdf66e07fa 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2219,9 +2219,9 @@ static void axienet_dma_err_handler(struct work_struct *work) ~(XAE_OPTION_TXEN | XAE_OPTION_RXEN)); axienet_set_mac_address(ndev, NULL); axienet_set_multicast_list(ndev); - axienet_setoptions(ndev, lp->options); napi_enable(&lp->napi_rx); napi_enable(&lp->napi_tx); + axienet_setoptions(ndev, lp->options); } /** |