diff options
| author | Arkadi Sharshevsky <arkadis@mellanox.com> | 2017-05-18 09:18:53 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-18 11:04:00 -0400 |
| commit | 6b1206bbbce6092b2ec412125300889e6e551bc2 (patch) | |
| tree | 4edd249eae86175b3b3075f6c4e133fe56b0f028 /drivers/net/ethernet | |
| parent | 6dd4aba36f2dca00c3b6976a0d59c5cee16ad545 (diff) | |
| download | linux-6b1206bbbce6092b2ec412125300889e6e551bc2.tar.gz linux-6b1206bbbce6092b2ec412125300889e6e551bc2.tar.bz2 linux-6b1206bbbce6092b2ec412125300889e6e551bc2.zip | |
mlxsw: spectrum_router: Fix rif counter freeing routine
During rif counter freeing the counter index can be invalid. Add check
of validity before freeing the counter.
Fixes: e0c0afd8aa4e ("mlxsw: spectrum: Support for counters on router interfaces")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 33cec1cc1642..9f89c4137d21 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -206,6 +206,9 @@ void mlxsw_sp_rif_counter_free(struct mlxsw_sp *mlxsw_sp, { unsigned int *p_counter_index; + if (!mlxsw_sp_rif_counter_valid_get(rif, dir)) + return; + p_counter_index = mlxsw_sp_rif_p_counter_get(rif, dir); if (WARN_ON(!p_counter_index)) return; |