summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet
diff options
context:
space:
mode:
authorAndre Guedes <andre.guedes@intel.com>2020-03-18 16:00:56 -0700
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2020-04-19 11:59:24 -0700
commita73eb651005eef079a6bf3b448d1b6eb607bc80b (patch)
tree2b5695b09f48cf080ec4aa5536362344aaf749b3 /drivers/net/ethernet
parent424045bec085575fe4818428e6a68dac7cca48f3 (diff)
downloadlinux-a73eb651005eef079a6bf3b448d1b6eb607bc80b.tar.gz
linux-a73eb651005eef079a6bf3b448d1b6eb607bc80b.tar.bz2
linux-a73eb651005eef079a6bf3b448d1b6eb607bc80b.zip
igc: Improve address check in igc_del_mac_filter()
igc_add_mac_filter() doesn't allow filters with invalid MAC address to be added to adapter->mac_table so, in igc_del_mac_filter(), we can early return if MAC address is invalid. No need to traverse the table. Signed-off-by: Andre Guedes <andre.guedes@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet')
-rw-r--r--drivers/net/ethernet/intel/igc/igc_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 2f6c8f7fa6f4..070df92bb4e9 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2246,7 +2246,7 @@ static int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr,
int rar_entries = hw->mac.rar_entry_count;
int i;
- if (is_zero_ether_addr(addr))
+ if (!is_valid_ether_addr(addr))
return -EINVAL;
/* Search for matching entry in the MAC table based on given address