summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2021-06-16 12:53:33 -0700
committerDavid S. Miller <davem@davemloft.net>2021-06-16 13:02:07 -0700
commit224004fbb033600715dbd626bceec10bfd9c58bc (patch)
tree99eb421d0fbd5f689ef408836600d7315aec8018 /drivers/net
parent99718abdc00e86e4f286dd836408e2834886c16e (diff)
downloadlinux-224004fbb033600715dbd626bceec10bfd9c58bc.tar.gz
linux-224004fbb033600715dbd626bceec10bfd9c58bc.tar.bz2
linux-224004fbb033600715dbd626bceec10bfd9c58bc.zip
sh_eth: Avoid memcpy() over-reading of ETH_SS_STATS
In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid intentionally reading across neighboring array fields. The memcpy() is copying the entire structure, not just the first array. Adjust the source argument so the compiler can do appropriate bounds checking. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/renesas/sh_eth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index c5b154868c1f..713d3629b4c1 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -2287,7 +2287,7 @@ static void sh_eth_get_strings(struct net_device *ndev, u32 stringset, u8 *data)
{
switch (stringset) {
case ETH_SS_STATS:
- memcpy(data, *sh_eth_gstrings_stats,
+ memcpy(data, sh_eth_gstrings_stats,
sizeof(sh_eth_gstrings_stats));
break;
}