diff options
| author | Christoph Hellwig <hch@lst.de> | 2020-06-03 07:14:43 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-06-04 21:16:11 -0600 |
| commit | d24de76af836260a99ca2ba281a937bd5bc55591 (patch) | |
| tree | 3e0982ad803e59fa210695684cfd58820cf9f86d /drivers/nvme | |
| parent | 6ac92fb5cdff6e5708199f1d5d9d58011ccc76a0 (diff) | |
| download | linux-d24de76af836260a99ca2ba281a937bd5bc55591.tar.gz linux-d24de76af836260a99ca2ba281a937bd5bc55591.tar.bz2 linux-d24de76af836260a99ca2ba281a937bd5bc55591.zip | |
block: remove the error argument to the block_bio_complete tracepoint
The status can be trivially derived from the bio itself. That also avoid
callers like NVMe to incorrectly pass a blk_status_t instead of the errno,
and the overhead of translating the blk_status_t to the errno in the I/O
completion fast path when no tracing is enabled.
Fixes: 35fe0d12c8a3 ("nvme: trace bio completion")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/nvme.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index fa5c75501049..c0f4226d3299 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -599,8 +599,7 @@ static inline void nvme_trace_bio_complete(struct request *req, struct nvme_ns *ns = req->q->queuedata; if (req->cmd_flags & REQ_NVME_MPATH) - trace_block_bio_complete(ns->head->disk->queue, - req->bio, status); + trace_block_bio_complete(ns->head->disk->queue, req->bio); } extern struct device_attribute dev_attr_ana_grpid; |