summaryrefslogtreecommitdiffstats
path: root/drivers/pci/controller
diff options
context:
space:
mode:
authorXinghui Li <korantli@tencent.com>2023-06-27 19:38:08 +0800
committerKrzysztof Wilczyński <kwilczynski@kernel.org>2023-09-18 14:08:30 +0000
commit4c64d708f99378e6719294cc63a77adf8eeb82b4 (patch)
treefb566f1d892bb0f1a5b0a4f05f252e6bef22937e /drivers/pci/controller
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d (diff)
downloadlinux-4c64d708f99378e6719294cc63a77adf8eeb82b4.tar.gz
linux-4c64d708f99378e6719294cc63a77adf8eeb82b4.tar.bz2
linux-4c64d708f99378e6719294cc63a77adf8eeb82b4.zip
PCI: vmd: Fix inconsistent indentation in vmd_resume()
The if-statement within the vmd_resume() function has an inconsistent indentation that leads to a compile time warning. Thus, correct the inconsistent indentation. While at it, remove the if-statement completely, which will make the code simpler. This was detected by Smatch: drivers/pci/controller/vmd.c:1066 vmd_resume() warn: inconsistent indenting No functional changes are intended. [kwilczynski: use correct tags, commit log] Suggested-by: Christoph Hellwig <hch@infradead.org> Link: https://lore.kernel.org/linux-pci/20230627113808.269716-1-korantwork@gmail.com Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Xinghui Li <korantli@tencent.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Diffstat (limited to 'drivers/pci/controller')
-rw-r--r--drivers/pci/controller/vmd.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index ad56df98b8e6..6cb55d7422ef 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -1078,10 +1078,7 @@ static int vmd_resume(struct device *dev)
struct vmd_dev *vmd = pci_get_drvdata(pdev);
int err, i;
- if (vmd->irq_domain)
- vmd_set_msi_remapping(vmd, true);
- else
- vmd_set_msi_remapping(vmd, false);
+ vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
for (i = 0; i < vmd->msix_count; i++) {
err = devm_request_irq(dev, vmd->irqs[i].virq,