diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2023-01-02 15:28:45 +0400 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2023-01-09 15:14:10 +0100 |
| commit | c818ae563bf99457f02e8170aabd6b174f629f65 (patch) | |
| tree | 3576116dcabd005f9f33c93aa51ab86ade750419 /drivers/pinctrl/pinctrl-rockchip.c | |
| parent | dcef18c8ac40aa85bb339f64c1dd31dd458b06fb (diff) | |
| download | linux-c818ae563bf99457f02e8170aabd6b174f629f65.tar.gz linux-c818ae563bf99457f02e8170aabd6b174f629f65.tar.bz2 linux-c818ae563bf99457f02e8170aabd6b174f629f65.zip | |
pinctrl: rockchip: Fix refcount leak in rockchip_pinctrl_parse_groups
of_find_node_by_phandle() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: d3e5116119bd ("pinctrl: add pinctrl driver for Rockchip SoCs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20230102112845.3982407-1-linmq006@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-rockchip.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-rockchip.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index da974ff2d75d..0bc3dc2220fd 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3036,6 +3036,7 @@ static int rockchip_pinctrl_parse_groups(struct device_node *np, np_config = of_find_node_by_phandle(be32_to_cpup(phandle)); ret = pinconf_generic_parse_dt_config(np_config, NULL, &grp->data[j].configs, &grp->data[j].nconfigs); + of_node_put(np_config); if (ret) return ret; } |