diff options
| author | Peng Wu <wupeng58@huawei.com> | 2022-11-22 08:22:42 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-11-22 17:05:05 +0000 |
| commit | c957387c402a1a213102e38f92b800d7909a728d (patch) | |
| tree | ae9b497f29d0caf83e8148c86d6325f73ad84db5 /drivers/regulator | |
| parent | 9211402fe72428bffe8e474448e671deeb6c52cb (diff) | |
| download | linux-c957387c402a1a213102e38f92b800d7909a728d.tar.gz linux-c957387c402a1a213102e38f92b800d7909a728d.tar.bz2 linux-c957387c402a1a213102e38f92b800d7909a728d.zip | |
regulator: of: fix a NULL vs IS_ERR() check in of_regulator_bulk_get_all()
The regulator_get() function never returns NULL. It returns error pointers.
Fixes: 27b9ecc7a9ba ("regulator: Add of_regulator_bulk_get_all")
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Link: https://lore.kernel.org/r/20221122082242.82937-1-wupeng58@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/of_regulator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 584c92f1a317..f7529f1bf8b2 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -767,7 +767,7 @@ restart: memcpy(name, prop->name, i); name[i] = '\0'; tmp = regulator_get(dev, name); - if (!tmp) { + if (IS_ERR(tmp)) { ret = -EINVAL; goto error; } |