summaryrefslogtreecommitdiffstats
path: root/drivers/rtc
diff options
context:
space:
mode:
authorTian Tao <tiantao6@hisilicon.com>2020-11-10 17:35:47 +0800
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2020-11-14 23:39:02 +0100
commitbc06cfc1c41e3b60b159132e5bba4c059a2e7f83 (patch)
treefcee9d7369d2a96cebb2584427db163357da6bd1 /drivers/rtc
parentc56ac7a0f468ceb38d24db41f4446d98ab94da2d (diff)
downloadlinux-bc06cfc1c41e3b60b159132e5bba4c059a2e7f83.tar.gz
linux-bc06cfc1c41e3b60b159132e5bba4c059a2e7f83.tar.bz2
linux-bc06cfc1c41e3b60b159132e5bba4c059a2e7f83.zip
rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler
Coccinelle noticed: drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Tian Tao <tiantao6@hisilicon.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/1605000947-32882-1-git-send-email-tiantao6@hisilicon.com
Diffstat (limited to 'drivers/rtc')
-rw-r--r--drivers/rtc/rtc-cpcap.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
index 800667d73a6f..38d576b0c4fa 100644
--- a/drivers/rtc/rtc-cpcap.c
+++ b/drivers/rtc/rtc-cpcap.c
@@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
rtc->alarm_irq = platform_get_irq(pdev, 0);
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
- cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
+ cpcap_rtc_alarm_irq,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_alarm", rtc);
if (err) {
dev_err(dev, "Could not request alarm irq: %d\n", err);
@@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
*/
rtc->update_irq = platform_get_irq(pdev, 1);
err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
- cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
+ cpcap_rtc_update_irq,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_1hz", rtc);
if (err) {
dev_err(dev, "Could not request update irq: %d\n", err);