diff options
| author | Gerd Bayer <gbayer@linux.ibm.com> | 2023-11-15 16:59:58 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-17 00:31:00 +0000 |
| commit | d565fa4300d9ebd5ba3bbd259ce841f8dab609d6 (patch) | |
| tree | 65257533aee74dab907164215f2c5293787b5a82 /drivers/s390/net/Kconfig | |
| parent | 0c3bd086d12d185650d095a906662593ec607bd0 (diff) | |
| download | linux-d565fa4300d9ebd5ba3bbd259ce841f8dab609d6.tar.gz linux-d565fa4300d9ebd5ba3bbd259ce841f8dab609d6.tar.bz2 linux-d565fa4300d9ebd5ba3bbd259ce841f8dab609d6.zip | |
s390/ism: ism driver implies smc protocol
Since commit a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
you can build the ism code without selecting the SMC network protocol.
That leaves some ism functions be reported as unused. Move these
functions under the conditional compile with CONFIG_SMC.
Also codify the suggestion to also configure the SMC protocol in ism's
Kconfig - but with an "imply" rather than a "select" as SMC depends on
other config options and allow for a deliberate decision not to build
SMC. Also, mention that in ISM's help.
Fixes: a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/netdev/afd142a2-1fa0-46b9-8b2d-7652d41d3ab8@infradead.org/
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net/Kconfig')
| -rw-r--r-- | drivers/s390/net/Kconfig | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/s390/net/Kconfig b/drivers/s390/net/Kconfig index 4902d45e929c..c61e6427384c 100644 --- a/drivers/s390/net/Kconfig +++ b/drivers/s390/net/Kconfig @@ -103,10 +103,11 @@ config CCWGROUP config ISM tristate "Support for ISM vPCI Adapter" depends on PCI + imply SMC default n help Select this option if you want to use the Internal Shared Memory - vPCI Adapter. + vPCI Adapter. The adapter can be used with the SMC network protocol. To compile as a module choose M. The module name is ism. If unsure, choose N. |