summaryrefslogtreecommitdiffstats
path: root/drivers/s390/net
diff options
context:
space:
mode:
authorErick Archer <erick.archer@outlook.com>2024-04-27 19:23:36 +0200
committerPaolo Abeni <pabeni@redhat.com>2024-04-30 11:39:03 +0200
commite5c5f3596de224422561d48eba6ece5210d967b3 (patch)
tree5b038bafe87afa83681499f42e0a52b1cba1f327 /drivers/s390/net
parent9f02bb6d7a229058ffaba4f6dd78e0f7b06b799c (diff)
downloadlinux-e5c5f3596de224422561d48eba6ece5210d967b3.tar.gz
linux-e5c5f3596de224422561d48eba6ece5210d967b3.tar.bz2
linux-e5c5f3596de224422561d48eba6ece5210d967b3.zip
sctp: prefer struct_size over open coded arithmetic
This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1][2]. As the "ids" variable is a pointer to "struct sctp_assoc_ids" and this structure ends in a flexible array: struct sctp_assoc_ids { [...] sctp_assoc_t gaids_assoc_id[]; }; the preferred way in the kernel is to use the struct_size() helper to do the arithmetic instead of the calculation "size + size * count" in the kmalloc() function. Also, refactor the code adding the "ids_size" variable to avoid sizing twice. This way, the code is more readable and safer. This code was detected with the help of Coccinelle, and audited and modified manually. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/160 [2] Signed-off-by: Erick Archer <erick.archer@outlook.com> Acked-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/PAXPR02MB724871DB78375AB06B5171C88B152@PAXPR02MB7248.eurprd02.prod.outlook.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/s390/net')
0 files changed, 0 insertions, 0 deletions