summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorSagi Grimberg <sagig@mellanox.com>2015-06-25 13:34:15 +0300
committerDoug Ledford <dledford@redhat.com>2015-07-14 13:20:09 -0400
commit3fdf70acec13efc7ecf254f5a364df06348bfd2c (patch)
tree9c463c5431b02863acc8a4af9ed02796b01aa232 /drivers/scsi
parentb356c1c1f90a347b6f67d9272dda7ecf47e0b46c (diff)
downloadlinux-3fdf70acec13efc7ecf254f5a364df06348bfd2c.tar.gz
linux-3fdf70acec13efc7ecf254f5a364df06348bfd2c.tar.bz2
linux-3fdf70acec13efc7ecf254f5a364df06348bfd2c.zip
IB/srp: Avoid using uninitialized variable
We might return res which is not initialized. Also reduce code duplication by exporting srp_parse_tmo so srp_tmo_set can reuse it. Detected by Coverity. Signed-off-by: Sagi Grimberg <sagig@mellanox.com> Signed-off-by: Jenny Falkovich <jennyf@mellanox.com> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/scsi_transport_srp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c
index a85292b1d09d..e3cd3ece4412 100644
--- a/drivers/scsi/scsi_transport_srp.c
+++ b/drivers/scsi/scsi_transport_srp.c
@@ -203,7 +203,7 @@ static ssize_t srp_show_tmo(char *buf, int tmo)
return tmo >= 0 ? sprintf(buf, "%d\n", tmo) : sprintf(buf, "off\n");
}
-static int srp_parse_tmo(int *tmo, const char *buf)
+int srp_parse_tmo(int *tmo, const char *buf)
{
int res = 0;
@@ -214,6 +214,7 @@ static int srp_parse_tmo(int *tmo, const char *buf)
return res;
}
+EXPORT_SYMBOL(srp_parse_tmo);
static ssize_t show_reconnect_delay(struct device *dev,
struct device_attribute *attr, char *buf)