summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorZhang Qilong <zhangqilong3@huawei.com>2020-12-05 19:55:51 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2020-12-07 17:35:10 -0500
commit97031ccffa4f62728602bfea8439dd045cd3aeb2 (patch)
tree2948623c364b5567bc0506eabda0f86e6c2f6bfa /drivers/scsi
parent62eebd5247c4e4ce08826ad5995cf4dd7ce919dd (diff)
downloadlinux-97031ccffa4f62728602bfea8439dd045cd3aeb2.tar.gz
linux-97031ccffa4f62728602bfea8439dd045cd3aeb2.tar.bz2
linux-97031ccffa4f62728602bfea8439dd045cd3aeb2.zip
scsi: pm80xx: Fix error return in pm8001_pci_probe()
The driver did not return an error in the case where pm8001_configure_phy_settings() failed. Use rc to store the return value of pm8001_configure_phy_settings(). Link: https://lore.kernel.org/r/20201205115551.2079471-1-zhangqilong3@huawei.com Fixes: 279094079a44 ("[SCSI] pm80xx: Phy settings support for motherboard controller.") Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/pm8001/pm8001_init.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 9a5d284f076a..ee2de177d0d0 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1127,7 +1127,8 @@ static int pm8001_pci_probe(struct pci_dev *pdev,
pm8001_init_sas_add(pm8001_ha);
/* phy setting support for motherboard controller */
- if (pm8001_configure_phy_settings(pm8001_ha))
+ rc = pm8001_configure_phy_settings(pm8001_ha);
+ if (rc)
goto err_out_shost;
pm8001_post_sas_ha_init(shost, chip);