diff options
author | Dmitry Kasatkin <dmitry.kasatkin@nokia.com> | 2011-04-20 13:34:58 +0300 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2011-04-26 16:45:38 +1000 |
commit | bf362759034cf208966dff262c7d740a6b1b3edd (patch) | |
tree | 60e3eb51fbc11e1c15a7b25c79ba8a6dd9db9f8a /drivers/scsi | |
parent | 528d26f57acd112fef78cd455db78e69a1ac39fd (diff) | |
download | linux-bf362759034cf208966dff262c7d740a6b1b3edd.tar.gz linux-bf362759034cf208966dff262c7d740a6b1b3edd.tar.bz2 linux-bf362759034cf208966dff262c7d740a6b1b3edd.zip |
crypto: omap-sham - hmac calculation bug fix for sha1 base hash
This patch fixes 2 hmac inter-dependent bugs.
1. "omap-sham: hash-in-progress is stored in hw format" commit introduced
optimization where temporary hash had been stored in OMAP specific format
(big endian).
For SHA1 it is different to real hash format, which is little endian.
Final HMAC value was calculated using incorrect hash.
Because CONFIG_CRYPTO_MANAGER_TESTS was disabled this error remained
unnoticed. After enabling this option, bug has been found.
2. HMAC was calculated using temporrary hash value.
For a single-request updates, temporary hash was the final one and
HMAC result was correct. But in fact only the final hash had to be used.
All crypto tests for HMAC produces only single request and
could not catch the problem. This problem is fixed here.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/scsi')
0 files changed, 0 insertions, 0 deletions