diff options
| author | Dafna Hirschfeld <dafna3@gmail.com> | 2018-09-30 22:04:03 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-02 14:53:18 -0700 |
| commit | ffa8ed13d9a55e7186324817a732722bf9c275dc (patch) | |
| tree | dc0e5f08fd8429559c6a4550936f7a81da3d3ad1 /drivers/staging/mt7621-mmc | |
| parent | f259e47af3ed47a39c36bb8cb17ba2f4ab4803f4 (diff) | |
| download | linux-ffa8ed13d9a55e7186324817a732722bf9c275dc.tar.gz linux-ffa8ed13d9a55e7186324817a732722bf9c275dc.tar.bz2 linux-ffa8ed13d9a55e7186324817a732722bf9c275dc.zip | |
staging: mt7621-mmc: Fix comparison to NULL
Replace comparisons of a variable 'x' to NULL with
either 'x' or '!x'.
Issues found with checkpatch.pl
Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/mt7621-mmc')
| -rw-r--r-- | drivers/staging/mt7621-mmc/sd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 8c32cec5950a..f2955fae7b28 100644 --- a/drivers/staging/mt7621-mmc/sd.c +++ b/drivers/staging/mt7621-mmc/sd.c @@ -851,8 +851,8 @@ static int msdc_do_request(struct mmc_host *mmc, struct mmc_request *mrq) #define SND_DAT 0 #define SND_CMD 1 - BUG_ON(mmc == NULL); - BUG_ON(mrq == NULL); + BUG_ON(!mmc); + BUG_ON(!mrq); host->error = 0; @@ -946,7 +946,7 @@ static int msdc_do_request(struct mmc_host *mmc, struct mmc_request *mrq) } done: - if (data != NULL) { + if (data) { host->data = NULL; dma_unmap_sg(mmc_dev(mmc), data->sg, data->sg_len, mmc_get_dma_dir(data)); @@ -1638,7 +1638,7 @@ static irqreturn_t msdc_irq(int irq, void *dev_id) } /* transfer complete interrupt */ - if (data != NULL) { + if (data) { if (inten & MSDC_INT_XFER_COMPL) { data->bytes_xfered = host->xfer_size; complete(&host->xfer_done); @@ -1661,7 +1661,7 @@ static irqreturn_t msdc_irq(int irq, void *dev_id) } /* command interrupts */ - if ((cmd != NULL) && (intsts & cmdsts)) { + if (cmd && (intsts & cmdsts)) { if ((intsts & MSDC_INT_CMDRDY) || (intsts & MSDC_INT_ACMDRDY) || (intsts & MSDC_INT_ACMD19_DONE)) { u32 *rsp = &cmd->resp[0]; |