diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-03-22 02:09:39 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-22 18:31:04 +0100 |
| commit | 960526d5970f80497ae500441adc2554c72dcf7e (patch) | |
| tree | 73261ef0cf2f4c622bf2494b9029425d28c2d20f /drivers/staging | |
| parent | 2a5f03b60a0cf59b305f10ff2dbc6cf84b280bba (diff) | |
| download | linux-960526d5970f80497ae500441adc2554c72dcf7e.tar.gz linux-960526d5970f80497ae500441adc2554c72dcf7e.tar.bz2 linux-960526d5970f80497ae500441adc2554c72dcf7e.zip | |
staging: mt7621-eth: fix return value check in mtk_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/mt7621-eth/mtk_eth_soc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c index 98b44629bc1d..dea4270478b1 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c @@ -2077,8 +2077,8 @@ static int mtk_probe(struct platform_device *pdev) return -ENOMEM; eth->base = devm_ioremap_resource(&pdev->dev, res); - if (!eth->base) - return -EADDRNOTAVAIL; + if (IS_ERR(eth->base)) + return PTR_ERR(eth->base); spin_lock_init(ð->page_lock); |