diff options
author | Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> | 2018-05-21 20:18:07 +0900 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-24 18:14:28 +0200 |
commit | 4a014a7339f441b0851ce012f469c0fadac61c81 (patch) | |
tree | f3837cf543a746965033a29c245f15e6fea6f133 /drivers/usb/usbip | |
parent | c97a8cc17f4472d85f889230ea6bac5aa8c53560 (diff) | |
download | linux-4a014a7339f441b0851ce012f469c0fadac61c81.tar.gz linux-4a014a7339f441b0851ce012f469c0fadac61c81.tar.bz2 linux-4a014a7339f441b0851ce012f469c0fadac61c81.zip |
usb: gadget: function: printer: avoid wrong list handling in printer_write()
When printer_write() calls usb_ep_queue(), a udc driver (e.g.
renesas_usbhs driver) may call usb_gadget_giveback_request() in
the udc .queue ops immediately. Then, printer_write() calls
list_add(&req->list, &dev->tx_reqs_active) wrongly. After that,
if we do unbind the printer driver, WARN_ON() happens in
printer_func_unbind() because the list entry is not removed.
So, this patch moves list_add(&req->list, &dev->tx_reqs_active)
calling before usb_ep_queue().
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/usbip')
0 files changed, 0 insertions, 0 deletions