diff options
author | Erick Archer <erick.archer@outlook.com> | 2024-04-06 16:23:37 +0200 |
---|---|---|
committer | Leon Romanovsky <leon@kernel.org> | 2024-04-11 13:46:47 +0300 |
commit | a68292eb431619a5f8db9d4868346837c5606424 (patch) | |
tree | afa7b722224ac290e8e47a73af409322e4a8dd80 /drivers/vfio | |
parent | 29b8e13a8b4c95ce629c8d4c84682f29af6f6bb5 (diff) | |
download | linux-a68292eb431619a5f8db9d4868346837c5606424.tar.gz linux-a68292eb431619a5f8db9d4868346837c5606424.tar.bz2 linux-a68292eb431619a5f8db9d4868346837c5606424.zip |
net: mana: Avoid open coded arithmetic
This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1][2].
As the "req" variable is a pointer to "struct mana_cfg_rx_steer_req_v2"
and this structure ends in a flexible array:
struct mana_cfg_rx_steer_req_v2 {
[...]
mana_handle_t indir_tab[] __counted_by(num_indir_entries);
};
the preferred way in the kernel is to use the struct_size() helper to
do the arithmetic instead of the calculation "size + size * count" in
the kzalloc() function.
Moreover, use the "offsetof" helper to get the indirect table offset
instead of the "sizeof" operator and avoid the open-coded arithmetic in
pointers using the new flex member. This new structure member also allow
us to remove the "req_indir_tab" variable since it is no longer needed.
Now, it is also possible to use the "flex_array_size" helper to compute
the size of these trailing elements in the "memcpy" function.
This way, the code is more readable and safer.
This code was detected with the help of Coccinelle, and audited and
modified manually.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/160 [2]
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Link: https://lore.kernel.org/r/AS8PR02MB7237A21355C86EC0DCC0D83B8B022@AS8PR02MB7237.eurprd02.prod.outlook.com
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/vfio')
0 files changed, 0 insertions, 0 deletions