summaryrefslogtreecommitdiffstats
path: root/drivers/virtio/Kconfig
diff options
context:
space:
mode:
authorWeilong Chen <chenweilong@huawei.com>2020-06-19 16:03:33 +0800
committerMichael S. Tsirkin <mst@redhat.com>2020-07-30 11:28:17 -0400
commita96b0d061d476093cf86ca1c2de06fc57163588d (patch)
tree56b833a7534a95a8cf95835261d893bd4d84324a /drivers/virtio/Kconfig
parent168c358af2f8c5a37f8b5f877ba2cc93995606ee (diff)
downloadlinux-a96b0d061d476093cf86ca1c2de06fc57163588d.tar.gz
linux-a96b0d061d476093cf86ca1c2de06fc57163588d.tar.bz2
linux-a96b0d061d476093cf86ca1c2de06fc57163588d.zip
virtio-mem: Fix build error due to improper use 'select'
As noted in: https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt "select should be used with care. select will force a symbol to a value without visiting the dependencies." Config VIRTIO_MEM should not select CONTIG_ALLOC directly. Otherwise it will cause an error: https://bugzilla.kernel.org/show_bug.cgi?id=208245 Signed-off-by: Weilong Chen <chenweilong@huawei.com> Link: https://lore.kernel.org/r/20200619080333.194753-1-chenweilong@huawei.com Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Acked-by: David Hildenbrand <david@redhat.com>
Diffstat (limited to 'drivers/virtio/Kconfig')
-rw-r--r--drivers/virtio/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 5809e5f5b157..5c92e4a50882 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -85,7 +85,7 @@ config VIRTIO_MEM
depends on VIRTIO
depends on MEMORY_HOTPLUG_SPARSE
depends on MEMORY_HOTREMOVE
- select CONTIG_ALLOC
+ depends on CONTIG_ALLOC
help
This driver provides access to virtio-mem paravirtualized memory
devices, allowing to hotplug and hotunplug memory.