summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorSuman Anna <s-anna@ti.com>2016-04-04 17:46:18 -0500
committerJoerg Roedel <jroedel@suse.de>2016-04-05 17:53:19 +0200
commit521f40823ebf2818045546d45aa378eba1c41717 (patch)
tree56a748cfe20e6f049f0e9fcfc7824560faa1127e /drivers
parent9735a22799b9214d17d3c231fe377fc852f042e9 (diff)
downloadlinux-521f40823ebf2818045546d45aa378eba1c41717.tar.gz
linux-521f40823ebf2818045546d45aa378eba1c41717.tar.bz2
linux-521f40823ebf2818045546d45aa378eba1c41717.zip
iommu/omap: Remove iopgtable_clear_entry_all() from driver remove
The function iopgtable_clear_entry_all() is used for clearing all the page table entries. These entries are neither created nor initialized during the OMAP IOMMU driver probe, and are managed only when a client device attaches to the IOMMU. So, there is no need to invoke this function on a driver remove. Removing this fixes a NULL pointer dereference crash if the IOMMU device is unbound from the driver with no client device attached to the IOMMU device. Signed-off-by: Suman Anna <s-anna@ti.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/iommu/omap-iommu.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 3dc5b65f3990..c05d48f88596 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -987,7 +987,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
{
struct omap_iommu *obj = platform_get_drvdata(pdev);
- iopgtable_clear_entry_all(obj);
omap_iommu_debugfs_remove(obj);
pm_runtime_disable(obj->dev);