diff options
author | Liao Chang <liaochang1@huawei.com> | 2023-08-08 09:29:51 +0800 |
---|---|---|
committer | Andi Shyti <andi.shyti@kernel.org> | 2023-08-10 10:13:30 +0200 |
commit | d29066600a85b15077221be404a38d9c4bf5b888 (patch) | |
tree | 28799365950aad8f0062a2b59593f58021c1bfea /drivers | |
parent | 605efbf43813857d8110ca0b5bda75f93426a789 (diff) | |
download | linux-d29066600a85b15077221be404a38d9c4bf5b888.tar.gz linux-d29066600a85b15077221be404a38d9c4bf5b888.tar.bz2 linux-d29066600a85b15077221be404a38d9c4bf5b888.zip |
i2c: pxa: Use dev_err_probe in probe function
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.
Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-7-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/i2c/busses/i2c-pxa.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 65a18d73be5c..2eae12c04854 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1404,10 +1404,9 @@ static int i2c_pxa_probe(struct platform_device *dev) strscpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name)); i2c->clk = devm_clk_get(&dev->dev, NULL); - if (IS_ERR(i2c->clk)) { - dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk)); - return PTR_ERR(i2c->clk); - } + if (IS_ERR(i2c->clk)) + return dev_err_probe(&dev->dev, PTR_ERR(i2c->clk), + "failed to get the clk\n"); i2c->reg_ibmr = i2c->reg_base + pxa_reg_layout[i2c_type].ibmr; i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr; |