diff options
| author | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2023-04-17 12:26:52 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-06-15 09:19:36 +0100 |
| commit | e9c154eed8aa166330eb0a8dc84642a8675c31e6 (patch) | |
| tree | 6220299f40119e4a8c969636373f17c9e3cd7709 /drivers | |
| parent | c452e3bd91b30a8ef7889fa06a50f54158c720d6 (diff) | |
| download | linux-e9c154eed8aa166330eb0a8dc84642a8675c31e6.tar.gz linux-e9c154eed8aa166330eb0a8dc84642a8675c31e6.tar.bz2 linux-e9c154eed8aa166330eb0a8dc84642a8675c31e6.zip | |
mfd: intel-m10-bmc: Move m10bmc_sys_read() away from header
Move m10bmc_sys_read() out from the header to prepare it for adding
more code into the function which would make it too large to be a
static inline any more.
While at it, replace the vague wording in function comment with more
precise statements.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Guenter Roeck <linux@roeck-us.net> # For hwmon
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230417092653.16487-4-ilpo.jarvinen@linux.intel.com
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/hwmon/intel-m10-bmc-hwmon.c | 1 | ||||
| -rw-r--r-- | drivers/mfd/intel-m10-bmc-core.c | 14 |
2 files changed, 15 insertions, 0 deletions
diff --git a/drivers/hwmon/intel-m10-bmc-hwmon.c b/drivers/hwmon/intel-m10-bmc-hwmon.c index 6512f4bec79a..6500ca548f9c 100644 --- a/drivers/hwmon/intel-m10-bmc-hwmon.c +++ b/drivers/hwmon/intel-m10-bmc-hwmon.c @@ -794,3 +794,4 @@ MODULE_DEVICE_TABLE(platform, intel_m10bmc_hwmon_ids); MODULE_AUTHOR("Intel Corporation"); MODULE_DESCRIPTION("Intel MAX 10 BMC hardware monitor"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(INTEL_M10_BMC_CORE); diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c index dab1bb152fd6..51f865174796 100644 --- a/drivers/mfd/intel-m10-bmc-core.c +++ b/drivers/mfd/intel-m10-bmc-core.c @@ -12,6 +12,20 @@ #include <linux/mfd/intel-m10-bmc.h> #include <linux/module.h> +/* + * This function helps to simplify the accessing of the system registers. + * + * The base of the system registers is configured through the struct + * csr_map. + */ +int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int *val) +{ + const struct m10bmc_csr_map *csr_map = m10bmc->info->csr_map; + + return m10bmc_raw_read(m10bmc, csr_map->base + offset, val); +} +EXPORT_SYMBOL_NS_GPL(m10bmc_sys_read, INTEL_M10_BMC_CORE); + int m10bmc_sys_update_bits(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int msk, unsigned int val) { |