diff options
| author | David Howells <dhowells@redhat.com> | 2018-05-10 14:12:50 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2018-05-14 13:17:35 +0100 |
| commit | f2686b09269ec1a6f23028b5675d87c3b4579a4c (patch) | |
| tree | b0191fde2c4c0f7aaf2b35354a58c6c2bb0e0c3f /fs/afs/server.c | |
| parent | 01fd79e6de74a447c5657913a335d9ce6508cdb1 (diff) | |
| download | linux-f2686b09269ec1a6f23028b5675d87c3b4579a4c.tar.gz linux-f2686b09269ec1a6f23028b5675d87c3b4579a4c.tar.bz2 linux-f2686b09269ec1a6f23028b5675d87c3b4579a4c.zip | |
afs: Fix giving up callbacks on server destruction
When a server record is destroyed, we want to send a message to the server
telling it that we're giving up all the callbacks it has promised us.
Apply two fixes to this:
(1) Only send the FS.GiveUpAllCallBacks message if we actually got a
callback from that server. We assume this to be the case if we
performed at least one successful FS operation on that server.
(2) Send it to the address last used for that server rather than always
picking the first address in the list (which might be unreachable).
Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/server.c')
| -rw-r--r-- | fs/afs/server.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/afs/server.c b/fs/afs/server.c index 629c74986cff..2c5cff60e34d 100644 --- a/fs/afs/server.c +++ b/fs/afs/server.c @@ -395,14 +395,16 @@ static void afs_destroy_server(struct afs_net *net, struct afs_server *server) struct afs_addr_list *alist = rcu_access_pointer(server->addresses); struct afs_addr_cursor ac = { .alist = alist, - .addr = &alist->addrs[0], .start = alist->index, - .index = alist->index, + .index = 0, + .addr = &alist->addrs[alist->index], .error = 0, }; _enter("%p", server); - afs_fs_give_up_all_callbacks(net, server, &ac, NULL); + if (test_bit(AFS_SERVER_FL_MAY_HAVE_CB, &server->flags)) + afs_fs_give_up_all_callbacks(net, server, &ac, NULL); + call_rcu(&server->rcu, afs_server_rcu); afs_dec_servers_outstanding(net); } |