diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2024-04-30 15:45:05 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-05-08 17:29:22 -0400 |
| commit | 6349b07c25a03dbad3ff0e9a20a27a367ddd2997 (patch) | |
| tree | a9b2c1becca1e22d2bdb2f8f20638782671b56da /fs/bcachefs | |
| parent | adf81796ee9cf2dd46214962a18015bffddbdbd2 (diff) | |
| download | linux-6349b07c25a03dbad3ff0e9a20a27a367ddd2997.tar.gz linux-6349b07c25a03dbad3ff0e9a20a27a367ddd2997.tar.bz2 linux-6349b07c25a03dbad3ff0e9a20a27a367ddd2997.zip | |
bcachefs: bch2_have_enough_devs() checks for nonexistent device
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs')
| -rw-r--r-- | fs/bcachefs/replicas.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/fs/bcachefs/replicas.c b/fs/bcachefs/replicas.c index f2c99703c730..f8ff7c8bb05e 100644 --- a/fs/bcachefs/replicas.c +++ b/fs/bcachefs/replicas.c @@ -947,18 +947,20 @@ bool bch2_have_enough_devs(struct bch_fs *c, struct bch_devs_mask devs, percpu_down_read(&c->mark_lock); for_each_cpu_replicas_entry(&c->replicas, e) { - unsigned i, nr_online = 0, nr_failed = 0, dflags = 0; + unsigned nr_online = 0, nr_failed = 0, dflags = 0; bool metadata = e->data_type < BCH_DATA_user; if (e->data_type == BCH_DATA_cached) continue; - for (i = 0; i < e->nr_devs; i++) { - struct bch_dev *ca = bch2_dev_bkey_exists(c, e->devs[i]); - + rcu_read_lock(); + for (unsigned i = 0; i < e->nr_devs; i++) { nr_online += test_bit(e->devs[i], devs.d); - nr_failed += ca->mi.state == BCH_MEMBER_STATE_failed; + + struct bch_dev *ca = bch2_dev_rcu(c, e->devs[i]); + nr_failed += ca && ca->mi.state == BCH_MEMBER_STATE_failed; } + rcu_read_unlock(); if (nr_failed == e->nr_devs) continue; |