diff options
| author | Qu Wenruo <wqu@suse.com> | 2024-01-05 16:05:55 +1030 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-03-04 16:24:45 +0100 |
| commit | 84cda1a6087d522548b7c8baac886c8e476be152 (patch) | |
| tree | e3ea77811e956c32568d549eeaadbf60ac1b09cb /fs/btrfs/disk-io.c | |
| parent | 4d02b543903f258bec4c8cdcb85ecbbb2a935cb4 (diff) | |
| download | linux-84cda1a6087d522548b7c8baac886c8e476be152.tar.gz linux-84cda1a6087d522548b7c8baac886c8e476be152.tar.bz2 linux-84cda1a6087d522548b7c8baac886c8e476be152.zip | |
btrfs: cache folio size and shift in extent_buffer
After the conversion to folio interfaces (but without the patch to
enable larger folio allocation), there is an LTP report about observable
performance drop on metadata heavy operations.
https://lore.kernel.org/linux-btrfs/202312221750.571925bd-oliver.sang@intel.com/
This drop is caused by the extra code of calculating the
folio_size()/folio_shift(), instead of the old hard coded
PAGE_SIZE/PAGE_SHIFT.
To slightly reduce the overhead, just cache both folio_size and
folio_shift in extent_buffer.
The two new members (u32 folio_size and u8 folio_shift) are stored
inside the holes of extent_buffer. folio_size is shared with len, which
is reduced to u32. The size of eb does not change.
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index c843563914ca..f405cc278861 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -193,7 +193,7 @@ static int btrfs_repair_eb_io_failure(const struct extent_buffer *eb, struct folio *folio = eb->folios[i]; u64 start = max_t(u64, eb->start, folio_pos(folio)); u64 end = min_t(u64, eb->start + eb->len, - folio_pos(folio) + folio_size(folio)); + folio_pos(folio) + eb->folio_size); u32 len = end - start; ret = btrfs_repair_io_failure(fs_info, 0, start, len, |