diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2021-05-19 08:40:11 +1000 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-05-19 19:19:20 -0500 |
| commit | d201d7631ca170b038e7f8921120d05eec70d7c5 (patch) | |
| tree | 5f0b595a798b4d81ca201ca7a2c148730c58b0c5 /fs/cifs | |
| parent | c0d46717b95735b0eacfddbcca9df37a49de9c7a (diff) | |
| download | linux-d201d7631ca170b038e7f8921120d05eec70d7c5.tar.gz linux-d201d7631ca170b038e7f8921120d05eec70d7c5.tar.bz2 linux-d201d7631ca170b038e7f8921120d05eec70d7c5.zip | |
cifs: fix memory leak in smb2_copychunk_range
When using smb2_copychunk_range() for large ranges we will
run through several iterations of a loop calling SMB2_ioctl()
but never actually free the returned buffer except for the final
iteration.
This leads to memory leaks everytime a large copychunk is requested.
Fixes: 9bf0c9cd4314 ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")
Cc: <stable@vger.kernel.org>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index dd0eb665b680..c693624a7267 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1861,6 +1861,8 @@ smb2_copychunk_range(const unsigned int xid, cpu_to_le32(min_t(u32, len, tcon->max_bytes_chunk)); /* Request server copy to target from src identified by key */ + kfree(retbuf); + retbuf = NULL; rc = SMB2_ioctl(xid, tcon, trgtfile->fid.persistent_fid, trgtfile->fid.volatile_fid, FSCTL_SRV_COPYCHUNK_WRITE, true /* is_fsctl */, (char *)pcchunk, |