summaryrefslogtreecommitdiffstats
path: root/fs/erofs/internal.h
diff options
context:
space:
mode:
authorJingbo Xu <jefflexu@linux.alibaba.com>2023-04-14 14:18:10 +0800
committerGao Xiang <hsiangkao@linux.alibaba.com>2023-04-17 01:15:54 +0800
commit1b3567a1969b26f709d82a874498c0754ea841c3 (patch)
treedb06f33e0421125b0aa08966f83b52dcf679faaf /fs/erofs/internal.h
parent4fdadd5b0f0c723c812842454f8cca1619f2e731 (diff)
downloadlinux-1b3567a1969b26f709d82a874498c0754ea841c3.tar.gz
linux-1b3567a1969b26f709d82a874498c0754ea841c3.tar.bz2
linux-1b3567a1969b26f709d82a874498c0754ea841c3.zip
erofs: fix potential overflow calculating xattr_isize
Given on-disk i_xattr_icount is 16 bits and xattr_isize is calculated from i_xattr_icount multiplying 4, xattr_isize has a theoretical maximum of 256K (64K * 4). Thus declare xattr_isize as unsigned int to avoid the potential overflow. Fixes: bfb8674dc044 ("staging: erofs: add erofs in-memory stuffs") Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> Reviewed-by: Chao Yu <chao@kernel.org> Link: https://lore.kernel.org/r/20230414061810.6479-1-jefflexu@linux.alibaba.com Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Diffstat (limited to 'fs/erofs/internal.h')
-rw-r--r--fs/erofs/internal.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index f1268cb6a37c..b5e91d7cc3f3 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -304,7 +304,7 @@ struct erofs_inode {
unsigned char datalayout;
unsigned char inode_isize;
- unsigned short xattr_isize;
+ unsigned int xattr_isize;
unsigned int xattr_shared_count;
unsigned int *xattr_shared_xattrs;