summaryrefslogtreecommitdiffstats
path: root/fs/ext4/block_validity.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-05-10 22:06:38 -0400
committerTheodore Ts'o <tytso@mit.edu>2019-05-10 22:06:38 -0400
commitfbbbbd2f28aec991f3fbc248df211550fbdfd58c (patch)
treee8aaa7d407923741c2dd3a307bb658aa66edc922 /fs/ext4/block_validity.c
parent08fc98a4d6424af66eb3ac4e2cedd2fc927ed436 (diff)
downloadlinux-fbbbbd2f28aec991f3fbc248df211550fbdfd58c.tar.gz
linux-fbbbbd2f28aec991f3fbc248df211550fbdfd58c.tar.bz2
linux-fbbbbd2f28aec991f3fbc248df211550fbdfd58c.zip
ext4: unsigned int compared against zero
There are two cases where u32 variables n and err are being checked for less than zero error values, the checks is always false because the variables are not signed. Fix this by making the variables ints. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/block_validity.c')
-rw-r--r--fs/ext4/block_validity.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
index 968f163b5feb..8d03550aaae3 100644
--- a/fs/ext4/block_validity.c
+++ b/fs/ext4/block_validity.c
@@ -142,7 +142,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino)
struct inode *inode;
struct ext4_sb_info *sbi = EXT4_SB(sb);
struct ext4_map_blocks map;
- u32 i = 0, err = 0, num, n;
+ u32 i = 0, num;
+ int err = 0, n;
if ((ino < EXT4_ROOT_INO) ||
(ino > le32_to_cpu(sbi->s_es->s_inodes_count)))