diff options
| author | xu xin <xu.xin16@zte.com.cn> | 2021-12-28 07:32:52 +0000 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-01-10 13:25:56 -0500 |
| commit | a2e3965df40af2f48ee6c97ed573adb91ced5dac (patch) | |
| tree | 8533c703653ff81bbd2f6b55fd8d6f2ab27bf9e6 /fs/ext4/ext4.h | |
| parent | da9e480212582b336b97848c69fdd4ac8860065b (diff) | |
| download | linux-a2e3965df40af2f48ee6c97ed573adb91ced5dac.tar.gz linux-a2e3965df40af2f48ee6c97ed573adb91ced5dac.tar.bz2 linux-a2e3965df40af2f48ee6c97ed573adb91ced5dac.zip | |
ext4: use BUG_ON instead of if condition followed by BUG
BUG_ON would be better.
This issue was detected with the help of Coccinelle.
Reported-by: Zeal robot <zealci@zte.com.cn>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
Link: https://lore.kernel.org/r/20211228073252.580296-1-xu.xin16@zte.com.cn
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ext4.h')
| -rw-r--r-- | fs/ext4/ext4.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 88c240a9cc42..715ee206dfe1 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2400,8 +2400,7 @@ ext4_rec_len_from_disk(__le16 dlen, unsigned blocksize) static inline __le16 ext4_rec_len_to_disk(unsigned len, unsigned blocksize) { - if ((len > blocksize) || (blocksize > (1 << 18)) || (len & 3)) - BUG(); + BUG_ON((len > blocksize) || (blocksize > (1 << 18)) || (len & 3)); #if (PAGE_SIZE >= 65536) if (len < 65536) return cpu_to_le16(len); |