diff options
| author | Yang Guo <guoyang2@huawei.com> | 2021-04-01 15:03:30 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2021-04-09 12:55:28 -0400 |
| commit | 3cd461712cb450ea6aa8a8200f35f24eb296bfb2 (patch) | |
| tree | ca9254cbf74dac7492060d30dd826b4c9cf5afcd /fs/ext4 | |
| parent | 72ffb49a7b623c92a37657eda7cc46a06d3e8398 (diff) | |
| download | linux-3cd461712cb450ea6aa8a8200f35f24eb296bfb2.tar.gz linux-3cd461712cb450ea6aa8a8200f35f24eb296bfb2.tar.bz2 linux-3cd461712cb450ea6aa8a8200f35f24eb296bfb2.zip | |
ext4: delete redundant uptodate check for buffer
The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Yang Guo <guoyang2@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/1617260610-29770-1-git-send-email-zhangshaokun@hisilicon.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inode.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0948a43f1b3d..32fa3ad38797 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1066,8 +1066,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, block_end = block_start + blocksize; if (block_end <= from || block_start >= to) { if (PageUptodate(page)) { - if (!buffer_uptodate(bh)) - set_buffer_uptodate(bh); + set_buffer_uptodate(bh); } continue; } @@ -1092,8 +1091,7 @@ static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len, } } if (PageUptodate(page)) { - if (!buffer_uptodate(bh)) - set_buffer_uptodate(bh); + set_buffer_uptodate(bh); continue; } if (!buffer_uptodate(bh) && !buffer_delay(bh) && |