diff options
| author | Baokun Li <libaokun1@huawei.com> | 2024-03-19 19:33:25 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-05-02 23:48:31 -0400 |
| commit | e19089dff547c9e1f09712acc3536d7b0aa9ce3d (patch) | |
| tree | 69d998dfd3aa1279106166d80a3365531c7e734b /fs/ext4 | |
| parent | 261341a932d9244cbcd372a3659428c8723e5a49 (diff) | |
| download | linux-e19089dff547c9e1f09712acc3536d7b0aa9ce3d.tar.gz linux-e19089dff547c9e1f09712acc3536d7b0aa9ce3d.tar.bz2 linux-e19089dff547c9e1f09712acc3536d7b0aa9ce3d.zip | |
ext4: clean up s_mb_rb_lock to fix build warnings with C=1
Running sparse (make C=1) on mballoc.c we get the following warning:
fs/ext4/mballoc.c:3194:13: warning: context imbalance in
'ext4_mb_seq_structs_summary_start' - wrong count at exit
This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in
ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit
83e80a6e3543 ("ext4: use buckets for cr 1 block scan instead of rbtree"),
so remove the __acquires to silence the warning.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240319113325.3110393-10-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/mballoc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index dbf04f91516c..c65fac9b8c72 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3190,7 +3190,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset) } static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos) -__acquires(&EXT4_SB(sb)->s_mb_rb_lock) { struct super_block *sb = pde_data(file_inode(seq->file)); unsigned long position; |