diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2023-01-30 15:20:09 -0800 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2023-02-02 13:37:17 -0800 |
| commit | 3aa51c61cb4a4dcb40df51ac61171e9ac5a35321 (patch) | |
| tree | 3785815129e4783b97d2b9c8d33f934b4b3de140 /fs/f2fs/inode.c | |
| parent | 933141e4eb49d8b48721e2377835063a1e8fb823 (diff) | |
| download | linux-3aa51c61cb4a4dcb40df51ac61171e9ac5a35321.tar.gz linux-3aa51c61cb4a4dcb40df51ac61171e9ac5a35321.tar.bz2 linux-3aa51c61cb4a4dcb40df51ac61171e9ac5a35321.zip | |
f2fs: retry to update the inode page given data corruption
If the storage gives a corrupted node block due to short power failure and
reset, f2fs stops the entire operations by setting the checkpoint failure flag.
Let's give more chances to live by re-issuing IOs for a while in such critical
path.
Cc: stable@vger.kernel.org
Suggested-by: Randall Huang <huangrandall@google.com>
Suggested-by: Chao Yu <chao@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/inode.c')
| -rw-r--r-- | fs/f2fs/inode.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 61a991b490ee..28c9c72dda2a 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -724,18 +724,19 @@ void f2fs_update_inode_page(struct inode *inode) { struct f2fs_sb_info *sbi = F2FS_I_SB(inode); struct page *node_page; + int count = 0; retry: node_page = f2fs_get_node_page(sbi, inode->i_ino); if (IS_ERR(node_page)) { int err = PTR_ERR(node_page); - if (err == -ENOMEM) { - cond_resched(); + /* The node block was truncated. */ + if (err == -ENOENT) + return; + + if (err == -ENOMEM || ++count <= DEFAULT_RETRY_IO_COUNT) goto retry; - } else if (err != -ENOENT) { - f2fs_stop_checkpoint(sbi, false, - STOP_CP_REASON_UPDATE_INODE); - } + f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_UPDATE_INODE); return; } f2fs_update_inode(inode, node_page); |