diff options
author | Jon Derrick <jonathan.derrick@intel.com> | 2018-07-02 18:45:18 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2018-07-02 18:45:18 -0400 |
commit | a17712c8e4be4fa5404d20e9cd3b2b21eae7bc56 (patch) | |
tree | 5e7904cf0721942898da5e47ff811091252644f4 /fs/inode.c | |
parent | bfe0a5f47ada40d7984de67e59a7d3390b9b9ecc (diff) | |
download | linux-a17712c8e4be4fa5404d20e9cd3b2b21eae7bc56.tar.gz linux-a17712c8e4be4fa5404d20e9cd3b2b21eae7bc56.tar.bz2 linux-a17712c8e4be4fa5404d20e9cd3b2b21eae7bc56.zip |
ext4: check superblock mapped prior to committing
This patch attempts to close a hole leading to a BUG seen with hot
removals during writes [1].
A block device (NVME namespace in this test case) is formatted to EXT4
without partitions. It's mounted and write I/O is run to a file, then
the device is hot removed from the slot. The superblock attempts to be
written to the drive which is no longer present.
The typical chain of events leading to the BUG:
ext4_commit_super()
__sync_dirty_buffer()
submit_bh()
submit_bh_wbc()
BUG_ON(!buffer_mapped(bh));
This fix checks for the superblock's buffer head being mapped prior to
syncing.
[1] https://www.spinics.net/lists/linux-ext4/msg56527.html
Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs/inode.c')
0 files changed, 0 insertions, 0 deletions